Repository navigation
Conversation
ijlee2
marked this pull request as ready for review
October 20, 2026 08:02
ijlee2
commented
Oct 20, 2026
Comment on lines
+36
to
+37
| env: | ||
| NODE_AUTH_TOKEN: "some-token" # Fork of @percy/ember uses yarn@v1, which requires NODE_AUTH_TOKEN |
Owner
Author
There was a problem hiding this comment.
TODO
Remove it after percy/percy-ember#1210 is merged and published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Patches #324.
In #322, I introduced a fork of
@percy/ember, which usesyarn@v1to manage its dependencies. It turned out thatyarn@v1requiresNODE_AUTH_TOKEN, whilepnpmdisplays only a warning if the variable is missing.The error thrown by
yarnprevents the publish workflow from succeeding.Run pnpm install --frozen-lockfile pnpm install --frozen-lockfile shell: /usr/bin/bash -e {0} env: NODE_VERSION: 22 PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc [WARN] Failed to replace env in config: ${NODE_AUTH_TOKEN} in .npmrc key "_authToken" Scope: all 9 workspace projects ? Verifying lockfile against supply-chain policies (1477 entries)... Packages are hard linked from the content-addressable store to the virtual store. Content-addressable store is at: /home/runner/setup-pnpm/node_modules/.bin/store/v11 Virtual store is at: node_modules/.pnpm Downloading @rolldown/binding-linux-x64-gnu@1.2.14: 0.00 B/8.27 MB Downloading pdfjs-dist@2.16.105: 0.00 B/9.85 MB ../../../../../tmp/.tmp382JNr yarn-install$ yarn install ../../../../../tmp/.tmp382JNr yarn-install: ...gine-1.22.22-2778-1792482454975044909 | Progress: resolved 1, reused 0, downloaded 0, added 0 ../../../../../tmp/.tmp382JNr yarn-install: Packages are copied from the content-addressable store to the virtual store. ../../../../../tmp/.tmp382JNr yarn-install: Content-addressable store is at: /home/runner/setup-pnpm/node_modules/.bin/package-manager-store/v11 ../../../../../tmp/.tmp382JNr yarn-install: Virtual store is at: ../../home/runner/setup-pnpm/node_modules/.bin/package-manager-store/v11/links ../../../../../tmp/.tmp382JNr yarn-install: ...gine-1.22.22-2778-1792482454975044909 | Progress: resolved 1, reused 0, downloaded 1, added 1, done ../../../../../tmp/.tmp382JNr yarn-install: ../../../../../tmp/.tmp382JNr yarn-install: dependencies: ../../../../../tmp/.tmp382JNr yarn-install: + yarn 1.22.22 ../../../../../tmp/.tmp382JNr yarn-install: ../../../../../tmp/.tmp382JNr yarn-install: yarn install v1.22.22 ../../../../../tmp/.tmp382JNr yarn-install: error Error: Failed to replace env in config: ${NODE_AUTH_TOKEN} ../../../../../tmp/.tmp382JNr yarn-install: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. ../../../../../tmp/.tmp382JNr yarn-install: Failed ✓ Lockfile passes supply-chain policies (1477 entries in 2.8s) Lockfile is up to date, resolution step is skipped Error: ERR_PNPM_PREPARE_PACKAGE × installing dependencies ╰─▶ Failed to prepare package: @percy/ember@5.0.2 yarn-install: `yarn install` exited with exit status: 1 Error: Process completed with exit code 1.